Exclude compiler service benchmark from VMR build when not building tests #16955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ No release notes required |
vzarytovskii
approved these changes
Mar 26, 2024
ViktorHofer
reviewed
Mar 27, 2024
tests/benchmarks/FCSBenchmarks/CompilerServiceBenchmarks/FSharp.Compiler.Benchmarks.fsproj
Outdated
Show resolved
Hide resolved
|
Should any other benchmark projects be also removed from that build then? |
I was only removing the projects that were blocking the build and causing issues. I think this one is an issue because other test projects weren't being built, and this project references them. |
ViktorHofer
approved these changes
Mar 27, 2024
psfinaki
approved these changes
Mar 27, 2024
psfinaki
added a commit
that referenced
this pull request
Mar 28, 2024
* PrettyNaming: make DoesIdentifierNeedBackticks public (#16613) * Update dependencies from https://github.com/dotnet/arcade build (#16944) Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.24170.6 -> To Version 8.0.0-beta.24172.5 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Unskip a few tests (#16946) * Unskip a few tests * another one * Fix [<tailcall>] false positive with yield! (#16933) * add test case showing a false positive with yield! * add missing case in IsAppInLambdaBody that can happen with yield! * add release notes entry * update PR number * only bind to what we are interested in * add test expecting a warning for yield! in a list comprehension * add test case using yield! in a custom CE that overflows the stack * Add regression test for nameof type with generic parameters (#16827) Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com> * Minor README update about proto (#16945) * Minor README update about proto It's Bootstrap actually. * Update DEVGUIDE.md Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com> * Update DEVGUIDE.md --------- Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com> * Compiled code benchmarks: easy benchmarking of `preview` against current (#16942) * Make it easy to bench preview against current * Revert EnableDefaultNoneItems false (#16953) * Exclude compiler service benchmark from VMR build when not building tests (#16955) * Exclude compiler service benchmark from VMR build when not building tests * remove Z --------- Co-authored-by: Petr <psfinaki@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/arcade build 20240326.8 (#16957) Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.24172.5 -> To Version 8.0.0-beta.24176.8 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> --------- Co-authored-by: Eugene Auduchinok <eugene.auduchinok@jetbrains.com> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Petr <psfinaki@users.noreply.github.com> Co-authored-by: dawe <dawedawe@posteo.de> Co-authored-by: Florian Verdonck <florian.verdonck@outlook.com> Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com> Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com> Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com> Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
This was referenced Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.