Fix StackOverflow in non-recursive bindings checker

[vzarytovskii]

Description

Fixes #16867 by making main recursive checking function non-cancellable (and tail recursive). It's hard to make builder work under stack guards, since it needs to be calling guard from Bind, ReturnFrom and BindReturn.

This also adds additional activity logging for the stack guards (only when subscribed).

@dotnet/fsharp-team-msft do we want to backport it to VS17.9?

Checklist

• Test cases added not applicable
• Performance benchmarks added in case of performance changes not applicable
• Release notes entry updated

[github-actions]

❗ Release notes required

---

✅ Found changes and release notes in following paths:

Change path	Release notes path	Description
src/Compiler	docs/release-notes/.FSharp.Compiler.Service/8.0.300.md

[vzarytovskii]

/run fantomas

[github-actions]

Ran fantomas: https://github.com/dotnet/fsharp/actions/runs/8360815685

[brianrourkeboll]

• Test cases added not applicable

Would a test that type-checks a module with a few thousand let-bindings not make sense?

[vzarytovskii]

• Test cases added not applicable

Would a test that type-checks a module with a few thousand let-bindings not make sense?

We have no way of running fscAnyCpu (and it's only reproduces on full CLR on any cpu) outside of fsharpqa, and I don't want to add it there since we try to get rid of it.

[T-Gro]

The description is a little misleading - the behavior is still cancellable, it just does not use the cancellable-builder/CE anymore, right?

[vzarytovskii]

The description is a little misleading - the behavior is still cancellable, it just does not use the cancellable-builder/CE anymore, right?

Well, yes and no. Before it could cancel on more occasions. Now it's only explicit in the beginning + when running cancellable inside.