Prefixed module nameof

[nojaf]

Description

This is a slight variation on #16550

Checklist

• Test cases added

• Performance benchmarks added in case of performance changes

• Release notes entry updated:

  Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

  Release notes files:

  • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
  • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/releae-notes/.Language/preview.md
  • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

  Information about the release notes entries format can be found in the documentation.
  Example:

  • More inlines for Result module. (PR #16106)
  • Correctly handle assembly imports with public key token of 0 length. (Issue #16359, PR #16363)
    *while! (Language suggestion #1038, PR #14238)

  If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

[github-actions]

❗ Release notes required

---

✅ Found changes and release notes in following paths:

Change path	Release notes path	Description
src/Compiler	docs/release-notes/.FSharp.Compiler.Service/8.0.300.md

[nojaf]

Hi @vzarytovskii, if possible could you do the backport thing? Would be nice if this makes it into a patch release.

[vzarytovskii]

Hi @vzarytovskii, if possible could you do the backport thing? Would be nice if this makes it into a patch release.

Which version? 20x?

[nojaf]

Yeah, whatever ships before 8.0.300.

[vzarytovskii]

/backport to release/dev17.9

[github-actions]

Started backporting to release/dev17.9: https://github.com/dotnet/fsharp/actions/runs/8006597118

[github-actions]

@vzarytovskii backporting to release/dev17.9 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Consider prefixed module name in nameof expression.
Applying: Consider prefixed module name in nameof pattern.
Applying: Remove foo
Applying: Update release notes
Using index info to reconstruct a base tree...
A	docs/release-notes/.FSharp.Compiler.Service/8.0.300.md
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): docs/release-notes/.FSharp.Compiler.Service/8.0.300.md deleted in HEAD and modified in Update release notes. Version Update release notes of docs/release-notes/.FSharp.Compiler.Service/8.0.300.md left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0004 Update release notes
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

[github-actions]

@vzarytovskii an error occurred while backporting to release/dev17.9, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

[vzarytovskii]

@nojaf auto-merge failed, could you please cherry-pick it and PR to 17.9?

[auduchinok]

@nojaf I think this may require more cases that can be parsed here and where a module name is allowed. For example, consider this:

nameof GenericType<Module.TypeInsideModule>

Maybe I'm missing something, but I thought this would be covered by a separate case in SynExpr.
If that's correct, I'd suggest going through all of its cases and checking what is allowed in nameof.