Add InvalidateConfiguration endpoint with FSharpProjectSnapshot.#16718
Merged
psfinaki merged 2 commits intodotnet:mainfrom Feb 16, 2024
Merged
Conversation
Contributor
|
0101
approved these changes
Feb 15, 2024
Contributor
0101
left a comment
There was a problem hiding this comment.
Don't know if we will use this API in the end, but makes sense for the transitional period.
Co-authored-by: Petr Pokorny <petr@innit.cz>
psfinaki
approved these changes
Feb 16, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hi there,
As some of you know, we take an interest in using the Transparent Compiler in Rider and Ionide.
Right now you can pass in
FSharpChecker.Create(..., useTransparentCompiler = bool).The new world uses FSharpProjectSnapshot instead of FSharpProjectOptions.
We would like to use the new snapshot APIs for everything. Imagine each editor has a setting for whether the end user is willing to use the new Transparent Compiler.
If the user says no (
useTransparentCompiler = false), every call to a snapshot-based endpoint is forwarded to a projectOptions one in the oldBackgroundCompiler(example).We don't want to mix
FSharpProjectSnapshotandFSharpProjectOptionsso we would like to address some of the gaps as we go along.This is a bit of a trade-off scenario but we want to avoid checks like this for each consumer.
Checklist
Test cases added
Performance benchmarks added in case of performance changes
Release notes entry updated: