add x bit to SmokeTestBenchmarks.sh#16700
Merged
psfinaki merged 1 commit intodotnet:mainfrom Feb 13, 2024
Merged
Conversation
Contributor
✅ No release notes required |
T-Gro
approved these changes
Feb 13, 2024
psfinaki
approved these changes
Feb 13, 2024
Contributor
psfinaki
left a comment
There was a problem hiding this comment.
Thanks for this - and for contributing to the benches in general lately :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While playing around with the benchmarks on unix I noticed we miss the x-bit on SmokeTestBenchmarks.sh
(No release notes needed)
Checklist
Test cases added
Performance benchmarks added in case of performance changes
Release notes entry updated: