Raise an error if we try to have interfaces with auto properties on constructor-less types#16352
Merged
T-Gro merged 19 commits intodotnet:mainfrom Dec 8, 2023
edgarfgp:internal-error-constructor-less-types
Merged
Raise an error if we try to have interfaces with auto properties on constructor-less types#16352T-Gro merged 19 commits intodotnet:mainfrom edgarfgp:internal-error-constructor-less-types
T-Gro merged 19 commits intodotnet:mainfrom
edgarfgp:internal-error-constructor-less-types
Conversation
edgarfgp
changed the title
…garfgp/fsharp into internal-error-constructor-less-types
Contributor
Author
|
This is ready |
T-Gro
reviewed
Nov 30, 2023
T-Gro
reviewed
Nov 30, 2023
T-Gro
reviewed
Nov 30, 2023
Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>
Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>
…s.fs Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>
edgarfgp
commented
Nov 30, 2023
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
|
Hey @edgarfgp good stuff here. In the PR description, you mention benchmarks, do you still plan to add them? |
Contributor
Author
Not applicable in this case. The check was there as part of the new PR template :). I guess I should remove it from the description |
Contributor
|
Ah okay, nevermind then :) |
psfinaki
approved these changes
Dec 5, 2023
vzarytovskii
reviewed
Dec 7, 2023
vzarytovskii
approved these changes
Dec 7, 2023
T-Gro
approved these changes
Dec 7, 2023
auduchinok
reviewed
Dec 7, 2023
auduchinok
reviewed
Dec 7, 2023
auduchinok
approved these changes
Dec 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist