Parens: only disallow removal from first expr in sequential expr when second on same line#16285
Merged
psfinaki merged 1 commit intodotnet:mainfrom Nov 15, 2023
Merged
Conversation
This was referenced Nov 15, 2023
T-Gro
approved these changes
Nov 15, 2023
psfinaki
approved these changes
Nov 15, 2023
Contributor
psfinaki
left a comment
psfinaki
left a comment
There was a problem hiding this comment.
Thanks for such a quick fix, awesome!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses an unforeseen interaction between #16262 and #16248.
4c36a98 from #16262 caused the test case in #16248 (comment) to hit this:
fsharp/src/Compiler/Service/ServiceAnalysis.fs
Line 1322 in 9e357ca
That should really only be if
expr1andexpr2are on the same line.