Skip to content

LexFilter: add more info to the indentation error #16053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 17, 2023

Conversation

auduchinok
Copy link
Member

Adds more info to LexFilter indentation errors. The requested idea was to tell about ways to (temporarily) opt-out from using the new indentation rules.

We will probably remove the indentation-strict- option in the future. We will also likely simplify this message back in one of the next F# releases.

@auduchinok auduchinok requested a review from a team as a code owner September 27, 2023 11:32
@vzarytovskii
Copy link
Member

This should go to release/dev17.8 branch if we want it in net8 release

@auduchinok auduchinok changed the base branch from main to release/dev17.8 September 27, 2023 13:15
@auduchinok auduchinok force-pushed the lexFilter-message branch 2 times, most recently from e060659 to 86dca7c Compare September 27, 2023 13:25
@auduchinok auduchinok closed this Oct 2, 2023
@auduchinok auduchinok reopened this Oct 2, 2023
@auduchinok auduchinok closed this Oct 2, 2023
@auduchinok auduchinok reopened this Oct 2, 2023
@vzarytovskii vzarytovskii merged commit ffef561 into dotnet:release/dev17.8 Oct 17, 2023
@auduchinok auduchinok deleted the lexFilter-message branch October 17, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants