Skip to content

Better error reporting for record expressions #15846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 25, 2023
Merged

Better error reporting for record expressions #15846

merged 11 commits into from
Aug 25, 2023

Conversation

@edgarfgp
Copy link
Contributor

@edgarfgp edgarfgp commented Aug 23, 2023 •
edited
Loading

Continuation of #15824

  • Add missing tests for pattern matching on records with duplicated fields

@edgarfgp
Copy link
Contributor Author

edgarfgp commented Aug 23, 2023

#15836 Should be merge first :)

edgarfgp
edgarfgp commented Aug 23, 2023
View reviewed changes
@edgarfgp edgarfgp marked this pull request as ready for review August 23, 2023 21:51
@edgarfgp edgarfgp requested a review from a team as a code owner August 23, 2023 21:51
@edgarfgp
Copy link
Contributor Author

edgarfgp commented Aug 24, 2023

This is ready

@edgarfgp edgarfgp mentioned this pull request Aug 24, 2023
Closed
@vzarytovskii vzarytovskii enabled auto-merge (squash) August 24, 2023 20:56
@vzarytovskii vzarytovskii merged commit a93cb3f into dotnet:main Aug 25, 2023
@allisonchou allisonchou mentioned this pull request Aug 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vzarytovskii vzarytovskii vzarytovskii approved these changes

+1 more reviewer

@0101 0101 0101 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edgarfgp @0101 @vzarytovskii