Update GetCSharpStyleIndexedExtensionMembersForTyconRef to avoid code duplication#15687
Merged
T-Gro merged 3 commits intodotnet:mainfrom Jul 27, 2023
edgarfgp:duplication-is-bad
Merged
Update GetCSharpStyleIndexedExtensionMembersForTyconRef to avoid code duplication#15687T-Gro merged 3 commits intodotnet:mainfrom edgarfgp:duplication-is-bad
T-Gro merged 3 commits intodotnet:mainfrom
edgarfgp:duplication-is-bad
Conversation
psfinaki
changed the title
psfinaki
approved these changes
Jul 26, 2023
T-Gro
approved these changes
Jul 27, 2023
auduchinok
reviewed
Dec 5, 2023
| /// Get the info for all the .NET-style extension members listed as static members in the type. | ||
| let private GetCSharpStyleIndexedExtensionMembersForTyconRef (amap: Import.ImportMap) m (tcrefOfStaticClass: TyconRef) = | ||
| let g = amap.g | ||
| let pri = NextExtensionMethodPriority() |
Member
There was a problem hiding this comment.
@edgarfgp Was there any reason to raise the priority for each type, even if it doesn't contain any extension members? Not that it makes a lot of difference, but the numbers are quite big now when debugging 🙂
Contributor
Author
There was a problem hiding this comment.
I think it was to reuse pri info in both places. But as you pointed it might not be the right thing to do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses a review comment from Don in #13839