Notinteractive #15184
Merged
Notinteractive #15184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not start a ControlledExecution block when the script is executing in --noninteractive mode.
A thread that is executing a ControlledExecution block cannot start a new ControlledExecution block. This is an issue for hosts that use fsi as a library to compile and execute scripts and want to use a ControlledExecution object to halt a threads execution.
Such hosts will typically use --noninteractive because they control the interactions with script processing. So, with this PR, we do not create a ControlledExecution when the script is noninteractive. Which enables the host to create a block and manage interactions.
Adds tests.