-
Notifications
You must be signed in to change notification settings - Fork 823
Fix cross-file navigation features when #line is used #12963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oh it's not against main. :-) |
This is now ready |
KevinRansom
approved these changes
Jul 13, 2022
vzarytovskii
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
This is about how VS and FCS behave when
#line
is used.This PR makes sure no line directives are applied for the incremental build, for the VS IDE, which now passes the hidden flag
--ignorelinedirectives
, similar to other hidden flags we pass such as--vserrors
. The same technique as #6004 is used - that is, the IDE directs the background build not to take line directives into account.Note some clients of FCS (e.g. Fable) definitely do want to take
#line
into account (because they are implementing a compiler).Desired specification
In general, the VS IDE should ignore
#line
. The current status for F# before this PR is#line
into account#line
into account#nowarn
works in generated source--ignorelinedirectives