Skip to content

Conversation

@KevinRansom
Copy link
Contributor

Now that we have shipped FSharp.Core and FCS nuget packages. Well almost ....

Update fcs build version to:
image

@KevinRansom KevinRansom requested a review from brettfo November 11, 2020 00:18
@brettfo
Copy link
Member

brettfo commented Nov 11, 2020

This change should be made directly in main, probably after #10420 comes in.

@KevinRansom
Copy link
Contributor Author

@brettfo , this is preparing for when we service. And I fully intend to cherry pick it into master.

@brettfo
Copy link
Member

brettfo commented Nov 11, 2020

We have auto-merges setup from 16.8 to main so you shouldn't have to cherry-pick anything.

@KevinRansom
Copy link
Contributor Author

@brettfo ahh nice ... I forgot that. Thx

member __.``System.Device.Gpio - Ensure we reference the runtime version of the assembly``() =
let code = """
#r "nuget:System.Device.Gpio"
#r "nuget:System.Device.Gpio, 1.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be fixed in main instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it's already merged.

@KevinRansom
Copy link
Contributor Author

It's fixed in main. This is release/dev16.8 which is a servicing branch, and so doesn't get automerges.

@KevinRansom KevinRansom merged commit 7fd0736 into dotnet:release/dev16.8 Nov 12, 2020
brettfo added a commit that referenced this pull request Nov 16, 2020
Back off part of #10422 because version numbers are hard and if we do need to service this, we'll have to pull in more substantial changes.
brettfo added a commit that referenced this pull request Nov 16, 2020
Back off part of #10422 because version numbers are hard and if we do need to service this, we'll have to pull in more substantial changes.
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
* :Increase package version

* Update gpio test
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
Back off part of dotnet#10422 because version numbers are hard and if we do need to service this, we'll have to pull in more substantial changes.
@KevinRansom KevinRansom deleted the updatefcsversion branch January 21, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants