Added fsx evaluation/running to new testing framework. #10106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onSession.EvalInteractionNonThrowing
vzarytovskii
commented
Sep 11, 2020
|
|
||
| function TestUsingXUnit([string] $testProject, [string] $targetFramework, [string]$testadapterpath) { | ||
| TestUsingMsBuild -testProject $testProject -targetFramework $targetFramework -testadapterpath $testadapterpath -noTestFilter $false | ||
| TestUsingMsBuild -testProject $testProject -targetFramework $targetFramework -testadapterpath $testadapterpath -noTestFilter $true |
Member
Author
There was a problem hiding this comment.
We shouldn't add tests filters, since xUnit doesn't understand it.
Member
Author
|
Ugh, macOS timeouts strike again. Will re-queue. |
KevinRansom
approved these changes
Sep 11, 2020
Contributor
KevinRansom
left a comment
KevinRansom
left a comment
There was a problem hiding this comment.
I like it, thanks for this.
Kevin
Contributor
|
mmmmmm yeah that lovely macos timeout, yeeeehaw |
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* Added fsx evaluation via the FSharpScript.Eval as well as FsiEvaluationSession.EvalInteractionNonThrowing * Turn off test filter for XUnit, and add to NUnit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
F# scripts can be evaluated via
New framework function
eval, takesCompilationUnit, returns result of evaluation (usesFSharpScript.Evalunder the hood) - returns result of evaluation + diagnostics + FsiValue, which can be examined (for now, only 2 functions were added, for checking type and value,withEvalTypeEqualsandwithEvalValueEqualsrespectively. More can be added later as needed.)New framework function
runFsi, takesCompilationUnit, returns result of evaluation (usesFsiEvaluationSession.EvalInteractionNonThrowingunder the hood) - will just run the script and return the result + output. Does not return FSharpErrorInfo, so need to check STDERR explicitly viawithStdErrContains. Basically, a wrapper around CompilerAssert'sRunScriptWithOptions.Addresses #9836