Skip to content

ILVerify check improvements #18090

Open
Open
@Martin521

Description

@Martin521

The new ILVerify check in CI certainly makes sense.

Here are just some inconveniences I met.

  • In most cases, there are just changes in line numbers.
  • In this case, there was probably some whitespace change at the end of the line, caused by a merge editor.

Can we assume "success" in these cases?

Or, more specific, implement this logic:

if baseline does not exist then
  run ilverify
  if TEST_UPDATE_BSL=1 then
    save output as .bsl
  else
    save output as .actual
  success
else
  run ilverify
  if output = baseline then
    success
  else
    show differences
    if TEST_UPDATE_BSL=1 then
      save output as .bsl
    else
      save output as .actual
    if output differs from baseline only in line numbers or line-end whitespace then
      success
    else
      failure

If that makes sense, I can support implementing it.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Status

    New

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions