Enable CodeQL for official builds #1734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

JoeRobich merged 1 commit into main from dev/jorobich/enable-codeql

Oct 7, 2022

Member

JoeRobich commented Oct 3, 2022

No description provided.


          Enable CodeQL for official builds

5aedfa2

jmarolf approved these changes

View reviewed changes

JoeRobich merged commit 32d497c into main

ghost added this to the Next milestone

Contributor

jmarolf commented Oct 7, 2022

This does not appear to work: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6796992&view=logs&j=20fcf628-b65c-5865-625a-1cef81cda63b&t=006ef424-ff5d-513d-109a-49079e979cfb

I think we need this variable to be set to true inside the job itself?

Contributor

jmarolf commented Oct 7, 2022

This is what I did in try-convert https://github.com/dotnet/try-convert/blob/main/eng/azure-pipelines.yml#L21-L22

And it is marked as true in the final build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2014636&view=logs&j=ff95f647-8cee-5d3f-5c1e-3f5594136373&t=00e1ee1c-34f0-54e6-7dc4-8bd0c16f0c16

Member Author

JoeRobich commented Oct 11, 2022

How weird

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet