Move Microsoft.Extensions.Diagnostics.ResourceMonitoring.Kubernetes to stable#7253
Merged
amadeuszl merged 8 commits intoMay 27, 2026
Merged
Conversation
Contributor
Author
|
@evgenyfedorov2 We probably should drop reading requests in Linux due to change in formula for weights from #7239. internal sealed class KubernetesResourceQuotaProvider : ResourceQuotaProvider
{
public override ResourceQuota GetResourceQuota()
{
ResourceQuota quota = new()
{
BaselineCpuInCores = ConvertMillicoreToCpuUnit(_kubernetesMetadata.RequestsCpu),
MaxCpuInCores = ConvertMillicoreToCpuUnit(_kubernetesMetadata.LimitsCpu),
BaselineMemoryInBytes = _kubernetesMetadata.RequestsMemory,
MaxMemoryInBytes = _kubernetesMetadata.LimitsMemory,
};
// On Linux, CPU requests are determined with weights, where eg. 1 CPUs' weight is equal to 1.02539062
// If we decide to read from K8s metadata it will have different results.
if (OperatingSystem.IsLinux())
{
if (_useLinuxCalculationV2)
{
quota.BaselineCpuInCores = _parser.GetCgroupRequestCpuV2();
}
else
{
quota.BaselineCpuInCores = _parser.GetCgroupRequestCpu();
}
}
if (quota.BaselineCpuInCores <= 0.0)
{
quota.BaselineCpuInCores = quota.MaxCpuInCores;
}
if (quota.BaselineMemoryInBytes == 0)
{
quota.BaselineMemoryInBytes = quota.MaxMemoryInBytes;
}
return quota;
}
} |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR transitions the Microsoft.Extensions.Diagnostics.ResourceMonitoring.Kubernetes library from experimental/dev stage to stable by removing experimental attributes and increasing quality thresholds. However, there is a critical issue with an invalid Stage value that must be corrected.
Changes:
- Removes experimental attribute injection and dev stage diagnostic ID (EXTEXP0016)
- Changes Stage from "dev" to "stable" (invalid - should be "normal")
- Increases MinMutationScore requirement from 90 to 95
…ing.Kubernetes/Microsoft.Extensions.Diagnostics.ResourceMonitoring.Kubernetes.csproj Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
Actually according to doc, we should measure it against pod specs, so we're good. |
Collaborator
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1437054&view=codecoverage-tab |
Collaborator
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1437154&view=codecoverage-tab |
evgenyfedorov2
approved these changes
May 27, 2026
dariusclay
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow