-
Notifications
You must be signed in to change notification settings - Fork 841
Doc updates #6930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc updates #6930
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR contributes to documentation improvements as part of issue #11392. The changes focus on standardizing terminology and improving clarity in XML documentation comments across the Microsoft.Extensions.AI.Abstractions library.
Key changes:
- Replaced hyphenated "strongly-typed" with "strongly typed" (non-hyphenated) for consistency
- Changed modal verbs from "may/may not" to "might/can" for better technical writing style
- Improved sentence structure and punctuation in documentation comments
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| AITool.cs | Updated "strongly-typed" to "strongly typed" in GetService method documentation |
| SpeechToTextOptions.cs | Updated "strongly-typed" to "strongly typed" in OptionsCallback property documentation |
| AIFunctionFactoryOptions.cs | Updated "strongly-typed" to "strongly typed" in MarshalResult property documentation |
| EmbeddingGenerationOptions.cs | Updated "strongly-typed" to "strongly typed" in OptionsCallback property documentation |
| IChatClient.cs | Updated "strongly-typed" to "strongly typed" in GetService method documentation |
| ChatResponseUpdate.cs | Changed modal verbs from "may" to "might/can" and improved punctuation throughout documentation |
| ChatResponse.cs | Changed modal verbs from "may" to "might/can" and improved sentence structure in documentation |
| ChatOptions.cs | Restructured property documentation using value tags, changed modal verbs, and updated "strongly-typed" to "strongly typed" |
src/Libraries/Microsoft.Extensions.AI.Abstractions/ChatCompletion/ChatOptions.cs
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.AI.Abstractions/ChatCompletion/ChatResponseUpdate.cs
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.AI.Abstractions/ChatCompletion/ChatResponse.cs
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.AI.Abstractions/ChatCompletion/ChatOptions.cs
Outdated
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.AI.Abstractions/ChatCompletion/ChatOptions.cs
Outdated
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.AI.Abstractions/ChatCompletion/ChatOptions.cs
Outdated
Show resolved
Hide resolved
…ion/ChatOptions.cs Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
…ion/ChatOptions.cs Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* doc updates --------- Co-authored-by: Stephen Toub <stoub@microsoft.com>
* doc updates --------- Co-authored-by: Stephen Toub <stoub@microsoft.com>
* doc updates --------- Co-authored-by: Stephen Toub <stoub@microsoft.com>
Contributes to dotnet/dotnet-api-docs#11392.
Microsoft Reviewers: Open in CodeFlow