Skip to content

Fix up comments in eval API json files #6452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025
Merged

Fix up comments in eval API json files #6452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ...icrosoft.Extensions.AI.Evaluation.Quality/Microsoft.Extensions.AI.Evaluation.Quality.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@
]
},
{
// After generating the baseline, manually edit this file to remove primary constructor portion
// This is needed until ICSharpCode.Decompiler adds support for primary constructors
// See: https://github.com/icsharpcode/ILSpy/issues/829
"Type": "sealed class Microsoft.Extensions.AI.Evaluation.Quality.CompletenessEvaluatorContext : Microsoft.Extensions.AI.Evaluation.EvaluationContext",
"Stage": "Stable",
"Methods": [
Expand Down Expand Up @@ -94,6 +97,9 @@
]
},
{
// After generating the baseline, manually edit this file to remove primary constructor portion
// This is needed until ICSharpCode.Decompiler adds support for primary constructors
// See: https://github.com/icsharpcode/ILSpy/issues/829
"Type": "sealed class Microsoft.Extensions.AI.Evaluation.Quality.EquivalenceEvaluatorContext : Microsoft.Extensions.AI.Evaluation.EvaluationContext",
"Stage": "Stable",
"Methods": [
Expand Down Expand Up @@ -162,6 +168,9 @@
]
},
{
// After generating the baseline, manually edit this file to remove primary constructor portion
// This is needed until ICSharpCode.Decompiler adds support for primary constructors
// See: https://github.com/icsharpcode/ILSpy/issues/829
"Type": "sealed class Microsoft.Extensions.AI.Evaluation.Quality.GroundednessEvaluatorContext : Microsoft.Extensions.AI.Evaluation.EvaluationContext",
"Stage": "Stable",
"Methods": [
Expand Down
10 changes: 5 additions & 5 deletions ...ons.AI.Evaluation.Reporting.Azure/Microsoft.Extensions.AI.Evaluation.Reporting.Azure.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@
]
},
{
// After generating the baseline, manually edit this file to have 'params' instead of 'scoped'
// This is needed until ICSharpCode.Decompiler adds params collection support
// See: https://github.com/icsharpcode/ILSpy/issues/829
// After generating the baseline, manually edit this file to remove primary constructor portion
// This is needed until ICSharpCode.Decompiler adds support for primary constructors
// See: https://github.com/icsharpcode/ILSpy/issues/829
"Type": "sealed class Microsoft.Extensions.AI.Evaluation.Reporting.Storage.AzureStorageResponseCacheProvider : Microsoft.Extensions.AI.Evaluation.Reporting.IEvaluationResponseCacheProvider",
"Stage": "Stable",
"Methods": [
Expand All @@ -37,8 +37,8 @@
]
},
{
// After generating the baseline, manually edit this file to have 'params' instead of 'scoped'
// This is needed until ICSharpCode.Decompiler adds params collection support
// After generating the baseline, manually edit this file to remove primary constructor portion
// This is needed until ICSharpCode.Decompiler adds support for primary constructors
// See: https://github.com/icsharpcode/ILSpy/issues/829
"Type": "sealed class Microsoft.Extensions.AI.Evaluation.Reporting.Storage.AzureStorageResultStore : Microsoft.Extensions.AI.Evaluation.Reporting.IEvaluationResultStore",
"Stage": "Stable",
Expand Down
24 changes: 12 additions & 12 deletions ...tensions.AI.Evaluation.Reporting/CSharp/Microsoft.Extensions.AI.Evaluation.Reporting.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@
]
},
{
// After generating the baseline, manually edit this file to have 'params' instead of 'scoped'
// This is needed until ICSharpCode.Decompiler adds params collection support
// See: https://github.com/icsharpcode/ILSpy/issues/829
// After generating the baseline, manually edit this file to remove primary constructor portion
// This is needed until ICSharpCode.Decompiler adds support for primary constructors
// See: https://github.com/icsharpcode/ILSpy/issues/829
"Type": "sealed class Microsoft.Extensions.AI.Evaluation.Reporting.ChatTurnDetails",
"Stage": "Stable",
"Methods": [
Expand Down Expand Up @@ -107,9 +107,9 @@
]
},
{
// After generating the baseline, manually edit this file to have 'params' instead of 'scoped'
// This is needed until ICSharpCode.Decompiler adds params collection support
// See: https://github.com/icsharpcode/ILSpy/issues/829
// After generating the baseline, manually edit this file to remove primary constructor portion
// This is needed until ICSharpCode.Decompiler adds support for primary constructors
// See: https://github.com/icsharpcode/ILSpy/issues/829
"Type": "sealed class Microsoft.Extensions.AI.Evaluation.Reporting.Storage.DiskBasedResponseCacheProvider : Microsoft.Extensions.AI.Evaluation.Reporting.IEvaluationResponseCacheProvider",
"Stage": "Stable",
"Methods": [
Expand Down Expand Up @@ -166,9 +166,9 @@
]
},
{
// After generating the baseline, manually edit this file to have 'params' instead of 'scoped'
// This is needed until ICSharpCode.Decompiler adds params collection support
// See: https://github.com/icsharpcode/ILSpy/issues/829
// After generating the baseline, manually edit this file to remove primary constructor portion
// This is needed until ICSharpCode.Decompiler adds support for primary constructors
// See: https://github.com/icsharpcode/ILSpy/issues/829
"Type": "sealed class Microsoft.Extensions.AI.Evaluation.Reporting.Formats.Html.HtmlReportWriter : Microsoft.Extensions.AI.Evaluation.Reporting.IEvaluationReportWriter",
"Stage": "Stable",
"Methods": [
Expand Down Expand Up @@ -241,9 +241,9 @@
]
},
{
// After generating the baseline, manually edit this file to have 'params' instead of 'scoped'
// This is needed until ICSharpCode.Decompiler adds params collection support
// See: https://github.com/icsharpcode/ILSpy/issues/829
// After generating the baseline, manually edit this file to remove primary constructor portion
// This is needed until ICSharpCode.Decompiler adds support for primary constructors
// See: https://github.com/icsharpcode/ILSpy/issues/829
"Type": "sealed class Microsoft.Extensions.AI.Evaluation.Reporting.Formats.Json.JsonReportWriter : Microsoft.Extensions.AI.Evaluation.Reporting.IEvaluationReportWriter",
"Stage": "Stable",
"Methods": [
Expand Down
Loading