Rename IChatClient members and corresponding types#5870
Merged
stephentoub merged 4 commits intodotnet:mainfrom Feb 11, 2025
Merged
Rename IChatClient members and corresponding types#5870stephentoub merged 4 commits intodotnet:mainfrom
stephentoub merged 4 commits intodotnet:mainfrom
Conversation
stephentoub
requested review from
JeremyLikness,
SteveSandersonMS,
eiriktsarpalis and
luisquintanilla
Collaborator
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=947185&view=codecoverage-tab |
After great feedback on usage of the APIs, re-reviewing the state of the ecosystem, and length discussions, we're renaming the members of IChatClient to destress the notion of "completions" and instead focus just on getting back a {streaming} response.
stephentoub
force-pushed
the
renamecompletions
branch
from
da2e0b4 to
4ae06da
Compare
Collaborator
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=947770&view=codecoverage-tab |
eiriktsarpalis
approved these changes
Feb 11, 2025
stephentoub
commented
Feb 11, 2025
stephentoub
commented
Feb 11, 2025
Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
…InferenceChatClient.cs Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
Collaborator
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=948177&view=codecoverage-tab |
Collaborator
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=948307&view=codecoverage-tab |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After great feedback on usage of the APIs, re-reviewing the state of the ecosystem, and length discussions, we're renaming the members of IChatClient to destress the notion of "completions" and instead focus just on getting back a {streaming} response.
Closes #5868
Microsoft Reviewers: Open in CodeFlow