Skip to content

Fix a few issues in IChatClient implementations #5549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 22, 2024
Merged

Fix a few issues in IChatClient implementations #5549

merged 2 commits into from
Oct 22, 2024

Conversation

@stephentoub
Copy link
Member

@stephentoub stephentoub commented Oct 22, 2024 •
edited by dotnet-policy-service bot
Loading

  • Avoid null arg exception when constructing system message with null text
  • Avoid empty exception when constructing user message with no parts
  • Use all parts rather than just first text part for system message
  • Handle assistant messages with both content and tools
  • Avoid unnecessarily trying to weed out duplicate call ids
Microsoft Reviewers: Open in CodeFlow

@stephentoub stephentoub requested a review from a team as a code owner October 22, 2024 01:53
@stephentoub
Fix a few issues in IChatClient implementations
787b84c 
- Avoid null arg exception when constructing system message with null text
- Avoid empty exception when constructing user message with no parts
- Use all parts rather than just first text part for system message
- Handle assistant messages with both content and tools
- Avoid unnecessarily trying to weed out duplicate call ids
@stephentoub
Address PR feedback
e93f1e6 
- Normalize null to string.Empty in TextContent
- Ensure GetContentParts always produces at least one part, even if empty text content
@stephentoub stephentoub merged commit 7cac12b into dotnet:main Oct 22, 2024
6 checks passed
@stephentoub stephentoub deleted the fixclients branch October 22, 2024 15:11
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
@jeffhandley jeffhandley added the area-ai Microsoft.Extensions.AI libraries label Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

@SteveSandersonMS SteveSandersonMS Awaiting requested review from SteveSandersonMS

@NTaylorMullen NTaylorMullen Awaiting requested review from NTaylorMullen

Assignees

@stephentoub stephentoub

Labels

area-ai Microsoft.Extensions.AI libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stephentoub @eiriktsarpalis @jeffhandley