Allowing tags to start with _ #5478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making it possible for namespaces to start with _. This is necessary to use OT exporter as it requires namespace overrides to start with _
carolineRe13
changed the title
|
Could you please add tests for this change too? Also, please provide more details on your use case, a small repro would be very useful. |
RussKie
added
the
waiting-author-feedback 📭
dotnet-policy-service
bot
removed
the
waiting-author-feedback 📭
|
@dotnet-policy-service agree company="Microsoft" |
|
As per the OpenTelemetry naming conventions https://opentelemetry.io/docs/specs/semconv/general/attribute-naming/#recommendations-for-opentelemetry-authors names must not start with an underscore. Will check if it applies here |
evgenyfedorov2
approved these changes
Oct 10, 2024
|
@carolineRe13 did you close it without merging? |
|
@evgenyfedorov2 was by accident |
|
This was discussed internally with the Geneva team; this change poses no issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making it possible for tags to start with _
We want to use OT exporter with code gen. However, to override namespaces, we need to pass a tag which starts with "_"
Microsoft Reviewers: Open in CodeFlow