Expose AddTcpEndpointProbe #4892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
geeknoid
reviewed
Jan 19, 2024
src/Libraries/Microsoft.Extensions.Diagnostics.Probes/TcpEndpointHealthCheckExtensions.cs
Outdated
Show resolved
Hide resolved
geeknoid
reviewed
Jan 19, 2024
There was a problem hiding this comment.
Change looks good, but let's rename the types and files please:
TcpEndpointProbesExtensions
TcpEndpointProbesService
TcpEndpointProbesOptions
TcpEndpointProbesOptionsValidator
The origin of this code had a different naming convention and use case. When we ported the code to dotnet/extensions, we only bothered renaming the public symbols. But now that you're making private stuff public, those should be renamed as well.
|
I renamed all the files and types as requested. |
geeknoid
reviewed
Jan 20, 2024
src/Libraries/Microsoft.Extensions.Diagnostics.Probes/TcpEndpointProbesExtensions.cs
Outdated
Show resolved
Hide resolved
joegoldman2
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4879.
Microsoft Reviewers: Open in CodeFlow