Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.Extensions.Diagnostics.HealthChecks.Common README #4680

Merged
merged 4 commits into from
Nov 8, 2023

Conversation

dariusclay
Copy link
Contributor

@dariusclay dariusclay commented Nov 7, 2023

null

Microsoft Reviewers: Open in CodeFlow

@ghost ghost assigned dariusclay Nov 7, 2023
@dariusclay dariusclay changed the title add summary information Microsoft.Extensions.Diagnostics.HealthChecks.Common README Nov 7, 2023
@dariusclay dariusclay marked this pull request as draft November 7, 2023 15:03
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch for taking care of this! Let us know when it is ready for review.

@@ -18,6 +22,9 @@ Or directly in the C# project file:
</ItemGroup>
```

## Usage Example

...coming soon...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming that's why this PR is marked as a draft? :)

@dariusclay dariusclay marked this pull request as ready for review November 7, 2023 21:30
@dariusclay
Copy link
Contributor Author

This is ready @joperezr

@joperezr joperezr merged commit cc3d912 into release/8.0 Nov 8, 2023
6 checks passed
@joperezr joperezr deleted the dletterman/update-readme-hcc branch November 8, 2023 17:48
@joperezr
Copy link
Member

joperezr commented Nov 8, 2023

Thanks @dariusclay !

@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants