Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources Health Check ReadMe #4678

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

Tratcher
Copy link
Member

@Tratcher Tratcher commented Nov 7, 2023

null

Microsoft Reviewers: Open in CodeFlow

@Tratcher Tratcher added this to the 8.0-rtm milestone Nov 7, 2023
@Tratcher Tratcher self-assigned this Nov 7, 2023
var builder = WebApplication.CreateBuilder(args);

builder.Services.AddHealthChecks()
.AddResourceUtilizationHealthCheck(o =>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious, is 'o' just the convention in extensions land for the param going to these builder delegates? or it is meant to stand for something

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is shorthand for options.

Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let me know when ready to merge.

…sourceUtilization/README.md

Co-authored-by: Sébastien Ros <sebastienros@gmail.com>
@joperezr joperezr merged commit 484e07a into dotnet:release/8.0 Nov 7, 2023
6 checks passed
@Tratcher Tratcher deleted the tratcher/readmes/health branch November 7, 2023 17:28
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants