Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Http resilience readme #4663

Merged
merged 6 commits into from
Nov 6, 2023
Merged

Http resilience readme #4663

merged 6 commits into from
Nov 6, 2023

Conversation

Tratcher
Copy link
Member

@Tratcher Tratcher commented Nov 2, 2023 •
edited by ghost
Loading

Descriptions borrowed from the API docs

Microsoft Reviewers: Open in CodeFlow

@Tratcher Tratcher added this to the 8.0-rtm milestone Nov 2, 2023
@Tratcher Tratcher self-assigned this Nov 2, 2023
@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.AspNetCore.Diagnostics.Middleware 99 100
Microsoft.Extensions.Telemetry 92 93

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=458982&view=codecoverage-tab

Tratcher and others added 2 commits November 3, 2023 10:31
@Tratcher
Update HttpStandardHedgingResilienceOptions.cs
cb47182
@Tratcher @martintmk
Apply suggestions from code review
fc7fb0a 
Co-authored-by: martintmk <103487740+martintmk@users.noreply.github.com>
@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Telemetry 92 93
Microsoft.AspNetCore.Diagnostics.Middleware 99 100

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=459580&view=codecoverage-tab

martintmk
martintmk reviewed Nov 3, 2023
View reviewed changes
src/Libraries/Microsoft.Extensions.Http.Resilience/README.md Outdated
clientBuilder.AddResilienceHandler("myHandler", b =>
{
b.AddConcurrencyLimiter(new ConcurrencyLimiterOptions())
.AddTimeout(new TimeoutStrategyOptions())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.AddTimeout(new TimeoutStrategyOptions())
.AddTimeout(new HttpTimeoutStrategyOptions())

It's better to use http specific options when possible. Applies to other as well. (retries, CB)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is HttpTimeoutStrategyOptions better when it doesn't have any properties? Why does it even exist?

@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Diagnostics.ResourceMonitoring 98 100

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=459625&view=codecoverage-tab

@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Diagnostics.ResourceMonitoring 98 100

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=459774&view=codecoverage-tab

@joperezr joperezr merged commit 22b61e2 into dotnet:release/8.0 Nov 6, 2023
6 checks passed
@Tratcher Tratcher deleted the tratcher/readmes/httpresil branch November 6, 2023 19:55
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@martintmk martintmk martintmk approved these changes

@sebastienros sebastienros Awaiting requested review from sebastienros

@RussKie RussKie Awaiting requested review from RussKie

@joperezr joperezr Awaiting requested review from joperezr

@geeknoid geeknoid Awaiting requested review from geeknoid

Assignees

@Tratcher Tratcher

Labels
None yet
Projects
None yet
Milestone
8.0-rtm
Development

Successfully merging this pull request may close these issues.
4 participants
@Tratcher @dotnet-comment-bot @martintmk @joperezr