Removing Microsoft.Extensions.EnumStrings #4639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
For the record, I strongly disagree with removing this functionality. |
geeknoid
approved these changes
Oct 31, 2023
RussKie
reviewed
Nov 9, 2023
Comment on lines
-64
to
-69
| | :---------------- | :---------- | | ||
| | `ENUMSTRGEN000` | Invalid extension namespace | | ||
| | `ENUMSTRGEN001` | Invalid attribute constructor used | | ||
| | `ENUMSTRGEN002` | Invalid extension class name | | ||
| | `ENUMSTRGEN003` | Invalid extension method name | | ||
| | `ENUMSTRGEN004` | Invalid enum type specified | |
There was a problem hiding this comment.
@joperezr have you deleted these from aka.ms?
There was a problem hiding this comment.
No. Can you please log an issue for that?
RussKie
reviewed
Nov 9, 2023
| @@ -64,14 +64,6 @@ internal static class DiagDescriptors | |||
| description: Resources.ArraysDescription, | |||
| defaultSeverity: DiagnosticSeverity.Warning); | |||
|
|
|||
| public static DiagnosticDescriptor EnumStrings { get; } = Make( | |||
| id: "EA0006", | |||
There was a problem hiding this comment.
ditto
The change also needs to be reflected in docs/list-of-diagnostics.md.
There was a problem hiding this comment.
Same here, would you mind logging an issue to clean things up if they weren't from this?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @geeknoid
As discussed offline, removing EnumStrings for now in favor of adding this functionality in .NET 9 as part of the platform using new roslyn features.
Microsoft Reviewers: Open in CodeFlow