Telemetry Abstractions API Surface #4375
Conversation
ghost
assigned 
...ions.Telemetry.Abstractions/NoDocs/Microsoft.Extensions.Http.Telemetry/TelemetryConstants.cs
Show resolved
Hide resolved
...ensions.Telemetry.Abstractions/NoDocs/Microsoft.Extensions.Http.Telemetry/RequestMetadata.cs
Show resolved
Hide resolved
| using System.Diagnostics.CodeAnalysis; | ||
| using Microsoft.Extensions.DependencyInjection; | ||
|
|
||
| namespace Microsoft.Extensions.Telemetry.Enrichment; |
There was a problem hiding this comment.
I see there are a lot of extension methods on IServiceCollection that aren't in the Microsoft.Extensions.DependencyInjection namespace. That's different to what existing Microsoft.Extensions.* packages which do use Microsoft.Extensions.DependencyInjection.
See dotnet/runtime#86885 as an example where this point came up.
Has this been discussed before? I think you should use Microsoft.Extensions.DependencyInjection unless there is a reason not to.
...s.Telemetry.Abstractions/NoDocs/Microsoft.Extensions.Telemetry.Logging/LoggerMessageState.cs
Show resolved
Hide resolved
| public KeyValuePair<string, object?>[] TagArray { get; } | ||
| public KeyValuePair<string, object?>[] RedactedTagArray { get; } | ||
| public ClassifiedTag[] ClassifiedTagArray { get; } |
There was a problem hiding this comment.
Returning arrays is odd. Are these intended to be editable? If not then ReadOnlyMemory or ReadOnlySpan would be better.
There was a problem hiding this comment.
This is a helper type for the logging code generator, and not intended to be used by customers directly. The type is documented as such, and the API is marked as EditorBrowsable=Never
|
@danmoseley This is intended for the internal R9 API review. #4373 is intended for the .NET team's commentary on stuff, that's why I added all the .NET folks as reviewers there. |
Please focus on APIs marked [Experimental]
Microsoft Reviewers: Open in CodeFlow