Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove generic Meter<T> #4342

Merged
merged 21 commits into from
Sep 27, 2023
Merged

Remove generic Meter<T> #4342

merged 21 commits into from
Sep 27, 2023

Conversation

xakep139
Copy link
Contributor

@xakep139 xakep139 commented Aug 31, 2023 •
edited by ghost
Loading

This fixes #4049

Microsoft Reviewers: Open in CodeFlow

@xakep139 xakep139 self-assigned this Aug 31, 2023
@xakep139 xakep139 linked an issue Aug 31, 2023 that may be closed by this pull request
Remove Meter<T> #4049
Closed
@xakep139 xakep139 requested a review from noahfalk August 31, 2023 16:45
noahfalk
noahfalk approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments inline, otherwise looked good 👍

src/Libraries/Microsoft.AspNetCore.HeaderParsing/HeaderParsingMetrics.cs Outdated Show resolved Hide resolved
src/Libraries/Microsoft.AspNetCore.HeaderParsing/HeaderParsingMetrics.cs Outdated Show resolved Hide resolved
@xakep139 xakep139 mentioned this pull request Sep 20, 2023
Closed
@xakep139 xakep139 marked this pull request as ready for review September 22, 2023 16:14
@xakep139 xakep139 changed the title [WIP] Remove generic Meter<T> Remove generic Meter<T> Sep 22, 2023
dariusclay
dariusclay approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@dariusclay dariusclay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just housekeeping remains for build to pass, looks good

@geeknoid geeknoid merged commit 0c28c73 into release/8.0 Sep 27, 2023
6 checks passed
@geeknoid geeknoid deleted the xakep139/remove-meter-of-T branch September 27, 2023 13:39
@xakep139 xakep139 mentioned this pull request Sep 27, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tekian tekian tekian approved these changes

@dariusclay dariusclay dariusclay approved these changes

@noahfalk noahfalk noahfalk approved these changes

@iliar-turdushev iliar-turdushev iliar-turdushev approved these changes

@geeknoid geeknoid geeknoid approved these changes

@martintmk martintmk Awaiting requested review from martintmk

@RussKie RussKie Awaiting requested review from RussKie

Assignees

@xakep139 xakep139

Labels
area-telemetry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Meter<T>
7 participants
@xakep139 @tekian @dariusclay @noahfalk @iliar-turdushev @geeknoid @martintmk