Remove the last ToBeRemoved component! #4278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
joperezr
reviewed
Aug 11, 2023
| @@ -30,7 +29,7 @@ public static IHealthChecksBuilder AddResourceUtilizationHealthCheck(this IHealt | |||
| _ = Throw.IfNull(builder); | |||
| _ = Throw.IfNull(tags); | |||
|
|
|||
| _ = builder.Services.AddValidatedOptions<ResourceUtilizationHealthCheckOptions, ResourceUtilizationHealthCheckOptionsValidator>(); | |||
| _ = builder.Services.AddOptionsWithValidateOnStart<ResourceUtilizationHealthCheckOptions, ResourceUtilizationHealthCheckOptionsValidator>(); | |||
There was a problem hiding this comment.
Assuming customers will also have to adapt for these sorts of changes, I wonder if this is something that UpgradeAssistant supports as well (meaning mapping static methods, since what we've done so far is mapping NuGet packages and renamed types) cc @RussKie
There was a problem hiding this comment.
This is not the only API rename :)
My understanding is that the .NET UA supports such conversions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null
Microsoft Reviewers: Open in CodeFlow