Add missing option validation #4260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
geeknoid
force-pushed
the
geeknoid/latency
branch
from
12d439e
to
76ca028
Compare
xakep139
reviewed
Aug 9, 2023
| @@ -79,7 +80,7 @@ private static void CheckNames(string[] names) | |||
|
|
|||
| private static void ConfigureOption(this IServiceCollection services, Action<LatencyContextRegistrationOptions> action) | |||
| { | |||
| _ = services.AddOptions<LatencyContextRegistrationOptions>(); | |||
| _ = services.AddValidatedOptions<LatencyContextRegistrationOptions, LatencyContextRegistrationOptionsValidator>(); | |||
There was a problem hiding this comment.
Do we need the options type to be public at all?
There was a problem hiding this comment.
I asked Ananth for feedback on that. Maybe we should hide it, we'll see what he ssys.
There was a problem hiding this comment.
He's OOF, so it'll take a while. We can address this in a separate PR.
joperezr
reviewed
Aug 9, 2023
...crosoft.Extensions.Telemetry.Abstractions/Microsoft.Extensions.Telemetry.Abstractions.csproj
Show resolved
Hide resolved
joperezr
approved these changes
Aug 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null
Microsoft Reviewers: Open in CodeFlow