Remove experimental label from FakeTimeProvider

[geeknoid]

• Fixed a bug in the API lifecycle analyzer which complained when I removed the experimental attribute and shouldn't have.

• Reenable a bunch of analyzer tests that got turned off at some point during debugging and never turned back on.

Microsoft Reviewers: Open in CodeFlow

[joperezr]

Looks like several tests in the Microsoft.Analyzers.Local.Tests are broken by this:

[xUnit.net 00:00:05.50]     Microsoft.Extensions.LocalAnalyzers.ApiLifecycle.Test.ApiLifecycleAnalyzerTest.Analyzer_Reports_Diagnostics_When_StableCode_Was_Not_Found_In_The_Compilation(expectedDiagnostics: 0, fileName: "ApiLifecycle/Data/BufferWriter2.json", testAssemblyName: "BufferWriter2", ids: [], source: "\r\n            using System;\r\n            using"...) [FAIL]
[xUnit.net 00:00:05.50]       Assert.Equal() Failure
[xUnit.net 00:00:05.50]       Expected: 0
[xUnit.net 00:00:05.50]       Actual:   3
[xUnit.net 00:00:05.50]       Stack Trace:
[xUnit.net 00:00:05.50]         /_/test/Analyzers/Microsoft.Analyzers.Local.Tests/ApiLifecycle/ApiLifecycleAnalyzerTest.cs(76,0): at Microsoft.Extensions.LocalAnalyzers.ApiLifecycle.Test.ApiLifecycleAnalyzerTest.Analyzer_Reports_Diagnostics_When_StableCode_Was_Not_Found_In_The_Compilation(Int32 expectedDiagnostics, String fileName, String testAssemblyName, String[] ids, String source)
[xUnit.net 00:00:05.50]         --- End of stack trace from previous location ---
[xUnit.net 00:00:05.69]     Microsoft.Extensions.LocalAnalyzers.ApiLifecycle.Test.ApiLifecycleAnalyzerTest.Analyzer_Reports_Diagnostics_When_StableCode_Was_Not_Found_In_The_Compilation(expectedDiagnostics: 0, fileName: "ApiLifecycle/Data/Analyzers.json", testAssemblyName: "Microsoft.Extensions.Analyzers", ids: [], source: "\r\n                namespace Test;\r\n\r\n       "...) [FAIL]
[xUnit.net 00:00:05.69]       Assert.Equal() Failure
[xUnit.net 00:00:05.69]       Expected: 0
[xUnit.net 00:00:05.69]       Actual:   3
[xUnit.net 00:00:05.69]       Stack Trace:
[xUnit.net 00:00:05.69]         /_/test/Analyzers/Microsoft.Analyzers.Local.Tests/ApiLifecycle/ApiLifecycleAnalyzerTest.cs(76,0): at Microsoft.Extensions.LocalAnalyzers.ApiLifecycle.Test.ApiLifecycleAnalyzerTest.Analyzer_Reports_Diagnostics_When_StableCode_Was_Not_Found_In_The_Compilation(Int32 expectedDiagnostics, String fileName, String testAssemblyName, String[] ids, String source)
[xUnit.net 00:00:05.69]         --- End of stack trace from previous location ---

[geeknoid]

Huh, all these tests passed locally. Argh.

[geeknoid]

@joperezr All better now...

[joperezr]

LGTM