Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Don't publish Microsoft.AspNetCore.Testing (#4058)" #4234

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Revert "Don't publish Microsoft.AspNetCore.Testing (#4058)" #4234

merged 1 commit into from
Aug 2, 2023

Conversation

RussKie
Copy link
Member

@RussKie RussKie commented Aug 2, 2023 •
edited by ghost
Loading

This reverts commit 163e293.

Resolves #4057

Microsoft Reviewers: Open in CodeFlow

@ghost ghost assigned RussKie Aug 2, 2023
@RussKie RussKie enabled auto-merge (squash) August 2, 2023 00:36
@RussKie RussKie disabled auto-merge August 2, 2023 06:26
@RussKie RussKie merged commit c2c3ae7 into dotnet:main Aug 2, 2023
6 checks passed
@RussKie RussKie deleted the publish_aspnettesting branch August 2, 2023 06:26
@ghost ghost added this to the 8.0 RC1 milestone Aug 2, 2023
joperezr
joperezr reviewed Aug 2, 2023
View reviewed changes
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

RussKie added a commit that referenced this pull request Aug 8, 2023
@RussKie
Revert "Don't publish Microsoft.AspNetCore.Testing (#4058)" (#4234)
bd1b2c2 
This reverts commit 163e293.

Resolves #4057

(cherry picked from commit c2c3ae7)
@ghost ghost locked as resolved and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joperezr joperezr joperezr left review comments

@Tratcher Tratcher Awaiting requested review from Tratcher

@geeknoid geeknoid Awaiting requested review from geeknoid

Assignees

@RussKie RussKie

Labels
None yet
Projects
None yet
Milestone
8.0 RC1
Development

Successfully merging this pull request may close these issues.

Rename Microsoft.AspNetCore.Testing
2 participants
@RussKie @joperezr