Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generator cleanup before updating code gen. #4227

Merged
merged 1 commit into from
Jul 30, 2023
Merged

Generator cleanup before updating code gen. #4227

merged 1 commit into from
Jul 30, 2023

Commits on Jul 30, 2023

  1. Generator cleanup before updating code gen. 

    - Remove constraints about not starting log method names or log method
parameters with _, the code now dynamically picks non-conflicting
symbol names. There's still a potential conflict with the name of
redactor instances, but I'll be removing all those in my follow-on PR.

- Simplified logic around handling of template parameters. I couldn't
figure out what the code was doing, so it needed a bit of cleanup.

- Remove some dead code I stumbled on.

- Fix broken .resx file handling in the generators, I messed that up
when simplifying the Roslyn dependencies last week.
    Martin Taillefer committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    aded3ce View commit details
    Browse the repository at this point in the history