Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Api review update #4190

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Api review update #4190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ...braries/Microsoft.Extensions.Compliance.Abstractions/Classification/DataClassification.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

using System;
using System.Diagnostics.CodeAnalysis;
using Microsoft.Shared.DiagnosticIds;
using Microsoft.Shared.Diagnostics;

namespace Microsoft.Extensions.Compliance.Classification;
Expand Down Expand Up @@ -154,6 +153,5 @@ public static DataClassification Combine(DataClassification left, DataClassifica
/// Gets a string representation of this object.
/// </summary>
/// <returns>A string representing the object.</returns>
[Experimental(diagnosticId: Experiments.Compliance, UrlFormat = Experiments.UrlFormat)]
public override string ToString() => $"{TaxonomyName}:{Value:x}";
}
4 changes: 2 additions & 2 deletions ...soft.Extensions.Compliance.Abstractions/Microsoft.Extensions.Compliance.Abstractions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
},
{
"Member": "override string Microsoft.Extensions.Compliance.Classification.DataClassification.ToString();",
"Stage": "Experimental"
"Stage": "Stable"
}
],
"Fields": [
Expand Down Expand Up @@ -241,7 +241,7 @@
},
{
"Member": "bool Microsoft.Extensions.Compliance.Redaction.Redactor.TryRedact<T>(T value, System.Span<char> destination, out int charsWritten, System.ReadOnlySpan<char> format, System.IFormatProvider? provider = null);",
"Stage": "Experimental"
"Stage": "Stable"
}
]
},
Expand Down
2 changes: 0 additions & 2 deletions src/Libraries/Microsoft.Extensions.Compliance.Abstractions/Redaction/Redactor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
using System;
using System.Diagnostics.CodeAnalysis;
using System.Runtime.CompilerServices;
using Microsoft.Shared.DiagnosticIds;

#if !NETCOREAPP3_1_OR_GREATER
using System.Buffers;
Expand Down Expand Up @@ -200,7 +199,6 @@ public int Redact<T>(T value, Span<char> destination, string? format = null, IFo
/// <returns><see langword="true"/> if the destination buffer was large enough, otherwise <see langword="false"/>.</returns>
[SkipLocalsInit]
[SuppressMessage("Minor Code Smell", "S3247:Duplicate casts should not be made", Justification = "Avoid pattern matching to improve jitted code")]
[Experimental(diagnosticId: Experiments.Compliance, UrlFormat = Experiments.UrlFormat)]
public bool TryRedact<T>(T value, Span<char> destination, out int charsWritten, ReadOnlySpan<char> format, IFormatProvider? provider = null)
{
#if NET6_0_OR_GREATER
Expand Down