Remove a few #if that are no longer needed #4138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
geeknoid
force-pushed
the
geeknoid/preproc
branch
from
4df788a
to
d64e003
Compare
rafal-mz
approved these changes
Jun 28, 2023
| #else | ||
| w.TaskSource.TrySetCanceled(); | ||
| #endif | ||
| _ = w.TaskSource.TrySetCanceled(cancellationToken); |
There was a problem hiding this comment.
Shouldn't we await this? This is testing code, and discarding a task will ignore potential exceptions in TrySetCanceled.
There was a problem hiding this comment.
Wait for what? TrySetCanceled returns a boolean. And this is intentionally fire-and-forget so we don't care about the return value.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4001
Microsoft Reviewers: Open in CodeFlow