PooledObjectPolicy as abstract base class for avoiding interface call #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rynowak
reviewed
Feb 21, 2018
Member
rynowak
left a comment
rynowak
left a comment
There was a problem hiding this comment.
Overall this design change looks great!
Member
|
Yes, I prefer this to the dynamic code generation version. |
rynowak
reviewed
Feb 21, 2018
| public DefaultObjectPool(IPooledObjectPolicy<T> policy, int maximumRetained) | ||
| { | ||
| _policy = policy ?? throw new ArgumentNullException(nameof(policy)); | ||
| _fastPolicy = policy as PooledObjectPolicy<T>; |
Member
There was a problem hiding this comment.
This is worth a comment, explaining that this base class was introduced in 2.1 to avoid the interface call
Member
Author
There was a problem hiding this comment.
Ah, now I added the comment above. Is the intention still clear or should I move the comment to this line?
Member
|
I'm going to generate this whole class with emit next time you go on vacation |
rynowak
approved these changes
Feb 21, 2018
Member
|
That settles it, I'm never going on vacation again. |
eerhardt
added a commit
to eerhardt/machinelearning
that referenced
this pull request
Apr 1, 2020
Accesses to this list are not thread-safe because we can be enumerating it on one thread (in Return) while another thread adds to it (in Create). The list is unnecessary because the PredictionEngine will always be "rooted". Either it was being held in memory by someone who got the PredictionEngine from the pool, or it is being held by the ObjectPool itself. So it won't ever be GC'd, and the WeakReference is not doing anything. Also, inherit from PooledObjectPolicy instead of IPooledObjectPolicy, so it can take the "fastPolicy" path in DefaultObjectPool. (See dotnet/extensions#318). Fix dotnet#4981
eerhardt
added a commit
to dotnet/machinelearning
that referenced
this pull request
Apr 2, 2020
Accesses to this list are not thread-safe because we can be enumerating it on one thread (in Return) while another thread adds to it (in Create). The list is unnecessary because the PredictionEngine will always be "rooted". Either it was being held in memory by someone who got the PredictionEngine from the pool, or it is being held by the ObjectPool itself. So it won't ever be GC'd, and the WeakReference is not doing anything. Also, inherit from PooledObjectPolicy instead of IPooledObjectPolicy, so it can take the "fastPolicy" path in DefaultObjectPool. (See dotnet/extensions#318). Fix #4981
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For discussion see #317
This is the variant Abstract base class, addressing #317 (comment)