Move pinned Microsoft.Netcore.App down #2456
Conversation
Move the pinned dependency on `Microsoft.Netcore.App` to the bottom of versions.details.xml to prevent it being picked for CoherentParentDependencies CC @mmitche @dougbu - we think this will fix dotnet/efcore#18207
|
I think the CoherentParent algo made need a tweak to make sense in these cases (follow "newest" path I think), but this may fix it for now. |
| @@ -74,6 +70,11 @@ | |||
| <Uri>https://github.com/dotnet/core-setup</Uri> | |||
| <Sha>d34d1570bfdf669ed94b4c939b2f39a1650e2320</Sha> | |||
| </Dependency> | |||
| <!-- Keep this dependency at the bottom of ProductDependencies, else it will be picked as the parent for CoherentParentDependencies --> | |||
There was a problem hiding this comment.
Question: The CoherentParentDependency attributes point CoreFx dependencies to Microsoft.NETCore.App.Runtime.win-x64. Why does a pinned Microsoft.NETCore.App.Ref dependency matter?
There was a problem hiding this comment.
The theory is that CPD traverses through versions.details.xml files top-down, looking for the first dependency from the repo it's tracking backwards towards. So since EFCore depends on a core-setup package through Extensions, DARC looks through Extensions for a core-setup package to use for dependency calculation. When the first one it finds is the pinned 3.0.0 one, it uses that. This PR is a hack/workaround until we improve the CPD algorithm.
ghost
locked as resolved and limited conversation to collaborators
Move the pinned dependency on
Microsoft.Netcore.Appto the bottom of versions.details.xml to prevent it being picked for CoherentParentDependenciesCC @mmitche @dougbu - we think this will fix dotnet/efcore#18207