Extensions build is using warnAsError false

[ericstj]

Description

Both official build and PR validation are setting -warnAsError 0

This allowed warnings to creep in. These are only caught in the source-index leg since it happens to call a different entry point that doesn't apply this setting.

Reproduction Steps

Build eng/common/build.ps1 -restore -build -binarylog -ci

Expected behavior

build fails

Actual behavior

build succeeds since CI should protect against adding warnings

Regression?

Yes, regressed in 5ca1721

Known Workarounds

No response

Configuration

No response

Other information

Bug is here:

extensions/eng/build.ps1

Line 14 in a0e6496

[boolean] $warnAsError = $false, # NOTE: inverted the Arcade's default

extensions/eng/build.sh

Lines 131 to 134 in a0e6496

	# The Arcade's default is "warnAsError=true", we want the opposite by default.
	if [[ "$hasWarnAsError" == false ]]; then
	properties="$properties --warnAsError false"
	fi