Address API review feedback (#4400)

Co-authored-by: Martin Taillefer <mataille@microsoft.com>
dotnet · Sep 13, 2023 · dda618f · dda618f
1 parent 84bcbe4
commit dda618f
Show file tree

Hide file tree

Showing 72 changed files with 453 additions and 550 deletions.
diff --git a/bench/Libraries/Microsoft.AspNetCore.Telemetry.PerformanceTests/RedactionBenchmark.cs b/bench/Libraries/Microsoft.AspNetCore.Telemetry.PerformanceTests/RedactionBenchmark.cs
@@ -29,8 +29,8 @@ public class RedactionBenchmark
 
     public RedactionBenchmark()
     {
-        _routeParameterDataClasses.Add("userId", SimpleClassifications.PrivateData);
-        _routeParameterDataClasses.Add("chatId", SimpleClassifications.PrivateData);
+        _routeParameterDataClasses.Add("userId", FakeClassifications.PrivateData);
+        _routeParameterDataClasses.Add("chatId", FakeClassifications.PrivateData);
 
         _httpPath = "/users/{userId}/chats/{chatId}/test1/test2/{userId}";
         _stringBuilderPool = PoolFactory.CreateStringBuilderPool();

diff --git a/bench/Libraries/Microsoft.Extensions.Http.Resilience.PerformanceTests/HttpClientFactory.cs b/bench/Libraries/Microsoft.Extensions.Http.Resilience.PerformanceTests/HttpClientFactory.cs
@@ -69,7 +69,7 @@ public static ServiceProvider InitializeServiceProvider(params HedgingClientType
     private static void AddHedging(this IServiceCollection services, HedgingClientType clientType)
     {
         var clientBuilder = services.AddHttpClient(clientType.ToString(), client => client.Timeout = Timeout.InfiniteTimeSpan);
-        var hedgingBuilder = clientBuilder.AddStandardHedgingHandler().SelectPipelineByAuthority(SimpleClassifications.PublicData);
+        var hedgingBuilder = clientBuilder.AddStandardHedgingHandler().SelectPipelineByAuthority(FakeClassifications.PublicData);
         _ = clientBuilder.AddHttpMessageHandler<NoRemoteCallHandler>();
 
         if (clientType.HasFlag(HedgingClientType.NoRoutes))

diff --git a/bench/Libraries/Microsoft.Extensions.Http.Telemetry.PerformanceTests/HttpClientFactory.cs b/bench/Libraries/Microsoft.Extensions.Http.Telemetry.PerformanceTests/HttpClientFactory.cs
@@ -26,7 +26,7 @@ public static System.Net.Http.HttpClient CreateWithLoggingLogRequest(string file
             {
                 options.BodySizeLimit = readLimit;
                 options.RequestBodyContentTypes.Add(new("application/json"));
-                options.RequestHeadersDataClasses.Add("Content-Type", SimpleClassifications.PrivateData);
+                options.RequestHeadersDataClasses.Add("Content-Type", FakeClassifications.PrivateData);
             })
             .AddHttpMessageHandler<NoRemoteCallHandler>()
             .Services
@@ -49,7 +49,7 @@ public static System.Net.Http.HttpClient CreateWithLoggingLogResponse(string fil
             {
                 options.BodySizeLimit = readLimit;
                 options.ResponseBodyContentTypes.Add(new("application/json"));
-                options.ResponseHeadersDataClasses.Add("Content-Type", SimpleClassifications.PrivateData);
+                options.ResponseHeadersDataClasses.Add("Content-Type", FakeClassifications.PrivateData);
             })
             .AddHttpMessageHandler<NoRemoteCallHandler>()
             .Services
@@ -73,10 +73,10 @@ public static System.Net.Http.HttpClient CreateWithLoggingLogAll(string fileName
                 options.BodySizeLimit = readLimit;
 
                 options.RequestBodyContentTypes.Add(new("application/json"));
-                options.RequestHeadersDataClasses.Add("Content-Type", SimpleClassifications.PrivateData);
+                options.RequestHeadersDataClasses.Add("Content-Type", FakeClassifications.PrivateData);
 
                 options.ResponseBodyContentTypes.Add(new("application/json"));
-                options.ResponseHeadersDataClasses.Add("Content-Type", SimpleClassifications.PrivateData);
+                options.ResponseHeadersDataClasses.Add("Content-Type", FakeClassifications.PrivateData);
             })
             .AddHttpMessageHandler<NoRemoteCallHandler>()
             .Services
@@ -99,7 +99,7 @@ public static System.Net.Http.HttpClient CreateWithLoggingLogRequest_ChunkedEnco
             {
                 options.BodySizeLimit = readLimit;
                 options.RequestBodyContentTypes.Add("application/json");
-                options.RequestHeadersDataClasses.Add("Content-Type", SimpleClassifications.PrivateData);
+                options.RequestHeadersDataClasses.Add("Content-Type", FakeClassifications.PrivateData);
             })
             .AddHttpMessageHandler<NoRemoteCallNotSeekableHandler>()
             .Services
@@ -122,7 +122,7 @@ public static System.Net.Http.HttpClient CreateWithLoggingLogResponse_ChunkedEnc
             {
                 options.BodySizeLimit = readLimit;
                 options.ResponseBodyContentTypes.Add("application/json");
-                options.ResponseHeadersDataClasses.Add("Content-Type", SimpleClassifications.PrivateData);
+                options.ResponseHeadersDataClasses.Add("Content-Type", FakeClassifications.PrivateData);
             })
             .AddHttpMessageHandler<NoRemoteCallNotSeekableHandler>()
             .Services
@@ -146,10 +146,10 @@ public static System.Net.Http.HttpClient CreateWithLoggingLogAll_ChunkedEncoding
                 options.BodySizeLimit = readLimit;
 
                 options.RequestBodyContentTypes.Add("application/json");
-                options.RequestHeadersDataClasses.Add("Content-Type", SimpleClassifications.PrivateData);
+                options.RequestHeadersDataClasses.Add("Content-Type", FakeClassifications.PrivateData);
 
                 options.ResponseBodyContentTypes.Add("application/json");
-                options.ResponseHeadersDataClasses.Add("Content-Type", SimpleClassifications.PrivateData);
+                options.ResponseHeadersDataClasses.Add("Content-Type", FakeClassifications.PrivateData);
             })
             .AddHttpMessageHandler<NoRemoteCallNotSeekableHandler>()
             .Services

diff --git a/src/Libraries/Microsoft.AspNetCore.AsyncState/Microsoft.AspNetCore.AsyncState.json b/src/Libraries/Microsoft.AspNetCore.AsyncState/Microsoft.AspNetCore.AsyncState.json
@@ -1,5 +1,5 @@
 {
-  "Name": "Microsoft.AspNetCore.AsyncState, Version=9.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35",
+  "Name": "Microsoft.AspNetCore.AsyncState, Version=8.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35",
   "Types": [
     {
       "Type": "static class Microsoft.AspNetCore.AsyncState.AsyncStateHttpContextExtensions",

diff --git a/src/Libraries/Microsoft.AspNetCore.HeaderParsing/Microsoft.AspNetCore.HeaderParsing.csproj b/src/Libraries/Microsoft.AspNetCore.HeaderParsing/Microsoft.AspNetCore.HeaderParsing.csproj
@@ -14,7 +14,7 @@
   </PropertyGroup>
 
   <PropertyGroup>
-    <Stage>dev</Stage>
+    <Stage>normal</Stage>
     <MinCodeCoverage>100</MinCodeCoverage>
     <MinMutationScore>91</MinMutationScore>
   </PropertyGroup>