Add experimental diagnostics ids

dotnet · Jul 17, 2023 · d32c498 · d32c498
1 parent 5546e37
commit d32c498
Show file tree

Hide file tree

Showing 103 changed files with 213 additions and 4,440 deletions.
diff --git a/Directory.Build.targets b/Directory.Build.targets
@@ -35,9 +35,8 @@
     <!-- Prevent analyzer crashes from stopping things -->
     <NoWarn>$(NoWarn);AD0001</NoWarn>
 
-    <!-- R9A029 is for customers, not for this repo -->
-    <NoWarn>$(NoWarn);R9A029</NoWarn>
-
+    <!-- Experimental warnings are for customers, not for this repo -->
+    <NoWarn>$(NoWarn);EXTEXP0001;EXTEXP0002;EXTEXP0003;EXTEXP0004;EXTEXP0005;EXTEXP0006;EXTEXP0007;EXTEXP0008;EXTEXP0009;EXTEXP0010;EXTEXP0011</NoWarn>
 
     <!-- NU5104: A stable release of a package should not have a prerelease dependency -->
     <NoWarn>$(NoWarn);NU5104</NoWarn>

diff --git a/eng/MSBuild/Shared.props b/eng/MSBuild/Shared.props
@@ -1,6 +1,6 @@
 <Project>
   <ItemGroup>
-    <Compile Include="$(MSBuildThisFileDirectory)\..\..\src\Shared\WarningDefinitions.cs" LinkBase="Shared" />
+    <Compile Include="$(MSBuildThisFileDirectory)\..\..\src\Shared\DiagnosticIds\*.cs" LinkBase="Shared\DiagnosticIds" />
   </ItemGroup>
 
   <ItemGroup Condition="'$(InjectSharedThrow)' == 'true'">

diff --git a/...nalyzers/Microsoft.Extensions.ExtraAnalyzers/Common/CallAnalysis/CallAnalyzer.Handlers.cs b/...nalyzers/Microsoft.Extensions.ExtraAnalyzers/Common/CallAnalysis/CallAnalyzer.Handlers.cs
@@ -108,27 +108,5 @@ public void HandlePropertyReference(OperationAnalysisContext context)
                 }
             }
         }
-
-        public void HandleThrow(OperationAnalysisContext context)
-        {
-            var op = (IThrowOperation)context.Operation;
-
-            if (op.Exception is IConversionOperation convOp)
-            {
-                if (convOp.Operand is IObjectCreationOperation creationOp)
-                {
-                    if (creationOp.Type != null)
-                    {
-                        if (_state.ExceptionTypes.TryGetValue(creationOp.Type, out var handlers))
-                        {
-                            foreach (var handler in handlers)
-                            {
-                                handler(context, op);
-                            }
-                        }
-                    }
-                }
-            }
-        }
     }
 }
diff --git a/src/Analyzers/Microsoft.Extensions.ExtraAnalyzers/Common/CallAnalysis/CallAnalyzer.cs b/src/Analyzers/Microsoft.Extensions.ExtraAnalyzers/Common/CallAnalysis/CallAnalyzer.cs
@@ -17,7 +17,6 @@ public sealed partial class CallAnalyzer : DiagnosticAnalyzer
         DiagDescriptors.StartsEndsWith,
         DiagDescriptors.LegacyLogging,
         DiagDescriptors.StaticTime,
-        DiagDescriptors.StringFormat,
         DiagDescriptors.EnumStrings,
         DiagDescriptors.ValueTuple,
         DiagDescriptors.Arrays,
@@ -41,15 +40,13 @@ public override void Initialize(AnalysisContext context)
             _ = new StartsEndsWith(reg);
             _ = new StaticTime(reg);
             _ = new ValueTuple(reg);
-            _ = new StringFormat(reg);
             _ = new LegacyCollection(reg);
             _ = new Split(reg);
 
             var handlers = new Handlers(state);
             compilationStartContext.RegisterOperationAction(handlers.HandleInvocation, OperationKind.Invocation);
             compilationStartContext.RegisterOperationAction(handlers.HandleObjectCreation, OperationKind.ObjectCreation);
             compilationStartContext.RegisterOperationAction(handlers.HandlePropertyReference, OperationKind.PropertyReference);
-            compilationStartContext.RegisterOperationAction(handlers.HandleThrow, OperationKind.Throw);
         });
     }
 }
diff --git a/src/Analyzers/Microsoft.Extensions.ExtraAnalyzers/Common/CallAnalysis/StringFormat.cs b/src/Analyzers/Microsoft.Extensions.ExtraAnalyzers/Common/CallAnalysis/StringFormat.cs
diff --git a/src/Analyzers/Microsoft.Extensions.ExtraAnalyzers/Common/DiagDescriptors.cs b/src/Analyzers/Microsoft.Extensions.ExtraAnalyzers/Common/DiagDescriptors.cs
@@ -49,37 +49,7 @@ internal static class DiagDescriptors
         helpLinkUri: "https://TODO/r9a000",
         isEnabledByDefault: true);
 
-    // R9A001..R9A017 are retired
-
-    public static DiagnosticDescriptor StringFormat { get; } = new(
-        id: "R9A018",
-        messageFormat: Resources.StringFormatMessage,
-        title: Resources.StringFormatTitle,
-        category: Performance,
-        description: Resources.StringFormatDescription,
-        defaultSeverity: DiagnosticSeverity.Warning,
-        helpLinkUri: "https://TODO/r9a018",
-        isEnabledByDefault: true);
-
-    public static DiagnosticDescriptor UsingExcessiveDictionaryLookup { get; } = new(
-        id: "R9A019",
-        messageFormat: Resources.UsingExcessiveDictionaryLookupMessage,
-        title: Resources.UsingExcessiveDictionaryLookupTitle,
-        category: Performance,
-        description: Resources.UsingExcessiveDictionaryLookupDescription,
-        defaultSeverity: DiagnosticSeverity.Warning,
-        helpLinkUri: "https://TODO/r9a019",
-        isEnabledByDefault: true);
-
-    public static DiagnosticDescriptor UsingExcessiveSetLookup { get; } = new(
-        id: "R9A020",
-        messageFormat: Resources.UsingExcessiveSetLookupMessage,
-        title: Resources.UsingExcessiveSetLookupTitle,
-        category: Performance,
-        description: Resources.UsingExcessiveSetLookupDescription,
-        defaultSeverity: DiagnosticSeverity.Warning,
-        helpLinkUri: "https://TODO/r9a020",
-        isEnabledByDefault: true);
+    // R9A001..R9A020 are retired
 
     public static DiagnosticDescriptor UsingToStringInLoggers { get; } = new(
         id: "R9A021",
@@ -101,17 +71,7 @@ internal static class DiagDescriptors
         helpLinkUri: "https://TODO/r9a022",
         isEnabledByDefault: true);
 
-    // R9A023..R9A028 retired
-
-    public static DiagnosticDescriptor UsingExperimentalApi { get; } = new(
-        id: "R9A029",
-        messageFormat: Resources.UsingExperimentalApiMessage,
-        title: Resources.UsingExperimentalApiTitle,
-        category: Reliability,
-        description: Resources.UsingExperimentalApiDescription,
-        defaultSeverity: DiagnosticSeverity.Warning,
-        helpLinkUri: "https://TODO/r9a029",
-        isEnabledByDefault: true);
+    // R9A023..R9A029 retired
 
     public static DiagnosticDescriptor StartsEndsWith { get; } = new(
         id: "R9A030",
@@ -189,17 +149,7 @@ internal static class DiagDescriptors
         helpLinkUri: "https://TODO/r9a043",
         isEnabledByDefault: true);
 
-    public static DiagnosticDescriptor MakeArrayStatic { get; } = new(
-        id: "R9A044",
-        messageFormat: Resources.MakeArrayStaticMessage,
-        title: Resources.MakeArrayStaticTitle,
-        category: Performance,
-        description: Resources.MakeArrayStaticDescription,
-        defaultSeverity: DiagnosticSeverity.Warning,
-        helpLinkUri: "https://TODO/r9a044",
-        isEnabledByDefault: true);
-
-    // R9A045..R9A055 retired
+    // R9A044..R9A055 retired
 
     public static DiagnosticDescriptor AsyncCallInsideUsingBlock { get; } = new(
         id: "R9A056",

diff --git a/src/Analyzers/Microsoft.Extensions.ExtraAnalyzers/Common/FixAllProviders/ISequentialFixer.cs b/src/Analyzers/Microsoft.Extensions.ExtraAnalyzers/Common/FixAllProviders/ISequentialFixer.cs
diff --git a/.../Microsoft.Extensions.ExtraAnalyzers/Common/FixAllProviders/SequentialFixAllCodeAction.cs b/.../Microsoft.Extensions.ExtraAnalyzers/Common/FixAllProviders/SequentialFixAllCodeAction.cs