Cleanup unused properties

dotnet · Aug 11, 2023 · c7ce98b · c7ce98b
1 parent 5bb4869
commit c7ce98b
Show file tree

Hide file tree

Showing 7 changed files with 4 additions and 16 deletions.
diff --git a/eng/MSBuild/ProjectStaging.targets b/eng/MSBuild/ProjectStaging.targets
@@ -11,7 +11,7 @@
 
   <!-- Produce errors if we don't have all the right property values for normal stage -->
   <Target Name="_CheckNormalStageProps" Condition="'$(Stage)' == 'normal'" BeforeTargets="Build">
-    <Error Condition="'$(MinCodeCoverage)' != 'n/a' AND ('$(MinCodeCoverage)' &lt; 85)" Text="MinCodeCoverage property must be >= 85 for normal stage." />
+    <Error Condition="'$(MinCodeCoverage)' != 'n/a' AND ('$(MinCodeCoverage)' &lt; 80)" Text="MinCodeCoverage property must be >= 80 for normal stage." />
     <Error Condition="'$(MinMutationScore)' != 'n/a' AND ('$(MinMutationScore)' &lt; 50)" Text="MinMutationScore property must be >= 50 for normal stage." />
   </Target>
 

diff --git a/eng/scripts/ValidateProjectCoverage.ps1 b/eng/scripts/ValidateProjectCoverage.ps1
@@ -41,7 +41,6 @@ Get-ChildItem -Path src -Include '*.*sproj' -Recurse | ForEach-Object {
     $XmlDoc = [xml](Get-Content $_)
     $AssemblyName = Get-XmlValue $XmlDoc "//Project/PropertyGroup/AssemblyName"
     $MinCodeCoverage = Get-XmlValue $XmlDoc "//Project/PropertyGroup/MinCodeCoverage"
-    $TempMinCodeCoverage = Get-XmlValue $XmlDoc "//Project/PropertyGroup/TempMinCodeCoverage"
 
     if ([string]::IsNullOrWhiteSpace($AssemblyName)) {
         $AssemblyName = $_.BaseName
@@ -53,12 +52,6 @@ Get-ChildItem -Path src -Include '*.*sproj' -Recurse | ForEach-Object {
         return
     }
 
-    # Some projects currently fail code coverage checks. Allow to temporarily override the requirements
-    # TODO: This should eventually removed.
-    if (![string]::IsNullOrWhiteSpace($TempMinCodeCoverage)) {
-        $MinCodeCoverage = $TempMinCodeCoverage
-    }
-
     $ProjectToMinCoverageMap[$AssemblyName] = $MinCodeCoverage
 }
 

diff --git a/src/Analyzers/Microsoft.Analyzers.Local/Microsoft.Analyzers.Local.csproj b/src/Analyzers/Microsoft.Analyzers.Local/Microsoft.Analyzers.Local.csproj
@@ -13,7 +13,6 @@
 
   <PropertyGroup>
     <Stage>normal</Stage>
-    <TempMinCodeCoverage>75</TempMinCodeCoverage>
     <MinCodeCoverage>92</MinCodeCoverage>
     <MinMutationScore>87</MinMutationScore>
   </PropertyGroup>

diff --git a/src/Libraries/Microsoft.AspNetCore.Telemetry/Microsoft.AspNetCore.Telemetry.csproj b/src/Libraries/Microsoft.AspNetCore.Telemetry/Microsoft.AspNetCore.Telemetry.csproj
@@ -17,8 +17,7 @@
 
   <PropertyGroup>
     <Stage>normal</Stage>
-    <TempMinCodeCoverage>77</TempMinCodeCoverage>
-    <MinCodeCoverage>100</MinCodeCoverage>
+    <MinCodeCoverage>77</MinCodeCoverage>
     <MinMutationScore>90</MinMutationScore>
   </PropertyGroup>
 

diff --git a/...es/Microsoft.Extensions.Diagnostics.Probes/Microsoft.Extensions.Diagnostics.Probes.csproj b/...es/Microsoft.Extensions.Diagnostics.Probes/Microsoft.Extensions.Diagnostics.Probes.csproj
@@ -13,8 +13,7 @@
 
   <PropertyGroup>
     <Stage>dev</Stage>
-    <TempMinCodeCoverage>70</TempMinCodeCoverage>
-    <MinCodeCoverage>100</MinCodeCoverage>
+    <MinCodeCoverage>70</MinCodeCoverage>
     <MinMutationScore>75</MinMutationScore>
   </PropertyGroup>
 

diff --git a/src/Libraries/Microsoft.Extensions.Telemetry/Microsoft.Extensions.Telemetry.csproj b/src/Libraries/Microsoft.Extensions.Telemetry/Microsoft.Extensions.Telemetry.csproj
@@ -19,8 +19,7 @@
 
   <PropertyGroup>
     <Stage>normal</Stage>
-    <TempMinCodeCoverage>78</TempMinCodeCoverage>
-    <MinCodeCoverage>100</MinCodeCoverage>
+    <MinCodeCoverage>81</MinCodeCoverage>
     <MinMutationScore>90</MinMutationScore>
   </PropertyGroup>
 

diff --git a/src/Shared/Shared.csproj b/src/Shared/Shared.csproj
@@ -21,7 +21,6 @@
 
   <PropertyGroup>
     <Stage>normal</Stage>
-    <TempMinCodeCoverage>89</TempMinCodeCoverage>
     <MinCodeCoverage>100</MinCodeCoverage>
     <MinMutationScore>85</MinMutationScore>
   </PropertyGroup>