Skip to content

Add missing workload references to Musl native EMSDK #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

directhex
Copy link

Should be the missing fix for dotnet/sdk#32327 though likely these changes need to flow though to updated runtime (and maybe SDK) builds.

@directhex directhex merged commit 5cda864 into dotnet:main Jan 3, 2024
@akoeplinger
Copy link
Member

@directhex we need to backport this right?

@directhex
Copy link
Author

@directhex we need to backport this right?

It's a wider decision as to whether we want to backport the multiple related changes to enable support for building WASM/WASI with Alpine, since it's bringing two whole-ass new RIDs online (and switching the build OS for one of the pieces of EMSDK for all Linux platforms from Ubuntu to Mariner). @baronfel was exploring getting approval.

@akoeplinger
Copy link
Member

Ah ok, I only skimmed dotnet/sdk#32327 and didn't see that this is a musl-only issue.

@directhex
Copy link
Author

It's an intersection of issues causing Musl to pull in the non-Musl emsdk/mono-aot-cross (which is normal given the RID graph). Native Musl packages for the required parts missed the no-chance-set-in-stone deadline for 8.0, and as you can see from this issue, some bugs weren't properly discovered and fixed until this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants