Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The restriction theory still omits three collections advertised as accepting zero restrictions.
1 open finding
What changed in this PR
Corrects SQLite ADO.NET schema metadata and expands regression coverage.
Changes:
- Preserves normalized version revisions.
- Corrects
REAL,TEXT, andBLOBmetadata. - Expands zero-restriction collection tests.
| File | Description |
|---|---|
src/Microsoft.Data.Sqlite.Core/SqliteConnection.cs |
Corrects normalized versions and type metadata. |
test/Microsoft.Data.Sqlite.Tests/SqliteConnectionTest.cs |
Adds metadata and restriction tests. |
🧠 Review effort: Balanced
Comment on lines
+1592
to
+1595
| InlineData(nameof(DbMetaDataCollectionNames.ReservedWords), 0), | ||
| InlineData("Tables", 0), | ||
| InlineData("Columns", 0), | ||
| InlineData("Indexes", 0)] |
Contributor
Author
There was a problem hiding this comment.
Fixed in commit 390152ec98: the restriction theory now covers all eight collections advertising zero restrictions, including DataSourceInformation, DataTypes, and Restrictions. The core build and diff check pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #39188. This PR addresses the remaining metadata correctness issues identified during review.
Version.RevisioninDataSourceInformation.DataSourceProductVersionNormalized, using a fixed-width zero revision when SQLite reports a three-part version.REALas variable-length because SQLite uses dynamic typing.TEXTandBLOBIsUnsignedasDBNull.Valuebecause signedness is not applicable to nonnumeric types.Testing
REAL,TEXT, andBLOB.dotnet build src/Microsoft.Data.Sqlite.Core/Microsoft.Data.Sqlite.Core.csproj --no-restorepasses with 0 warnings and 0 errors.git diff --checkpasses.The focused test project could not be restored in this environment because the configured NuGet feeds were unavailable.