Repository navigation
Add Array.IndexOf translation for byte arrays in SQL Server and SQLite - #39203
Quattordici wants to merge 1 commit into
Conversation
Fixes dotnet#19287 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017JjLpRL7H9aZ3d5AzP9Qtp
|
@Quattordici please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
Fixes #19287
Summary
This PR adds support for translating
Array.IndexOf()calls on byte arrays to SQL for SQL Server and SQLite databases.Changes
Source Code Changes
SqlServerByteArrayMethodTranslator: Added translation for
Array.IndexOf()using theCHARINDEXfunction. The translation accounts for the difference in indexing (CHARINDEX is 1-based and returns 0 when not found, while Array.IndexOf is 0-based and returns -1).SqliteByteArrayMethodTranslator: Added translation for
Array.IndexOf()using theinstr()function. Similar to SQL Server, the translation adjusts for the 1-based indexing ofinstr().Refactoring: Extracted common byte conversion logic into helper methods (
ToSingleByteArrayin SQL Server translator andToSingleByteBlobin SQLite translator) to avoid duplication betweenContainsandIndexOftranslations.Test Coverage
ByteArrayTranslationsTestBase: Added 5 new test cases covering:
IndexOf_with_constant()- searching for a constant byte valueIndexOf_with_parameter()- searching for a parameter byte valueIndexOf_with_column()- searching for a column byte valueIndexOf_with_parameter_above_ascii_range()- handling non-ASCII byte valuesIndexOf_not_found()- verifying -1 is returned when value is not foundSqlServerByteArrayMethodTranslator tests: Added corresponding SQL verification tests for SQL Server translation output.
SqliteByteArrayMethodTranslator tests: Added corresponding SQL verification tests for SQLite translation output.
CosmosDB tests: Added expected translation failure tests (Cosmos doesn't support this translation).
Technical Details
The implementation properly handles: