Add ChangeTracker.GetEntriesForState()#37847
Merged
AndriySvyryd merged 6 commits intomainfrom Mar 4, 2026
Merged
Conversation
…>() methods Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add ChangeTracker.GetEntriesForState() to improve performance
Add ChangeTracker.GetEntriesForState()
Mar 4, 2026
There was a problem hiding this comment.
Pull request overview
This PR adds a new public ChangeTracker.GetEntriesForState() API (plus a generic overload) to efficiently enumerate tracked entries by EntityState without triggering DetectChanges(), targeting scenarios with large, long-lived contexts where change detection is too expensive.
Changes:
- Added
ChangeTracker.GetEntriesForState(...)andChangeTracker.GetEntriesForState<TEntity>(...)APIs which delegate toIStateManager.GetEntriesForState(...)without callingDetectChanges(). - Added unit tests validating no-
DetectChangesbehavior, per-state filtering, combined state queries, and generic type filtering.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/EFCore/ChangeTracking/ChangeTracker.cs | Introduces the two new public GetEntriesForState* APIs and XML documentation. |
| test/EFCore.Tests/ChangeTracking/ChangeTrackerTest.cs | Adds coverage for filtering and the “does not call DetectChanges” guarantee. |
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
AndriySvyryd
reviewed
Mar 4, 2026
Member
|
Thanks to @DamirLisak for inspiration |
roji
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes the internal
IStateManager.GetEntriesForState()as a public API onChangeTracker, enabling efficient querying of tracked entities by state without triggeringDetectChanges(). This is critical for long-lived contexts tracking many entities whereDetectChanges()is prohibitively expensive.ChangeTracker: non-genericGetEntriesForState()and genericGetEntriesForState<TEntity>(), both accepting boolean flags foradded,modified,deleted,unchanged(all defaultfalse)DetectChangescall — unlikeEntries(), these bypass change detection entirely, returning current tracker state as-isOriginal prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.