Add proper handling when a property’s backing field cannot be inferred or the unsafe accessor cannot be generated.#36720
Merged
AndriySvyryd merged 1 commit intodotnet:mainfrom Feb 28, 2026
Conversation
Contributor
Author
|
@dotnet-policy-service agree |
AndriySvyryd
requested changes
Sep 11, 2025
249ae47 to
6b86657
Compare
e14d1e2 to
353ea69
Compare
AndriySvyryd
approved these changes
Feb 27, 2026
Member
|
Thanks for your contribution |
There was a problem hiding this comment.
Pull request overview
This PR improves design-time compiled model generation (especially for --nativeaot) by replacing a NullReferenceException failure mode with a targeted InvalidOperationException and a new DesignStrings message when EF can’t determine the backing member to use.
Changes:
- Add a new design-time resource string
CompiledModelBackingFieldNotFoundand expose it viaDesignStrings. - Update
CSharpRuntimeModelCodeGeneratorto throw a clearerInvalidOperationExceptioninstead of flowing anullMemberInfointo unsafe-accessor name generation. - Add a new compiled-model scaffolding test covering the backing-field-not-found scenario.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/EFCore.Specification.Tests/Scaffolding/CompiledModelTestBase.cs | Adds a NativeAOT test case expecting the new error message and a new entity type used by that test. |
| src/EFCore.Design/Scaffolding/Internal/CSharpRuntimeModelCodeGenerator.cs | Adds a guard/exception when GetMemberInfo(...) yields null during unsafe-accessor registration. |
| src/EFCore.Design/Properties/DesignStrings.resx | Adds CompiledModelBackingFieldNotFound string (and reorders/moves some existing entries). |
| src/EFCore.Design/Properties/DesignStrings.Designer.cs | Adds the strongly-typed accessor for CompiledModelBackingFieldNotFound (and reflects resource reordering). |
Files not reviewed (1)
- src/EFCore.Design/Properties/DesignStrings.Designer.cs: Language not supported
src/EFCore.Design/Scaffolding/Internal/CSharpRuntimeModelCodeGenerator.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Design/Scaffolding/Internal/CSharpRuntimeModelCodeGenerator.cs
Show resolved
Hide resolved
src/EFCore.Design/Scaffolding/Internal/CSharpRuntimeModelCodeGenerator.cs
Outdated
Show resolved
Hide resolved
test/EFCore.Specification.Tests/Scaffolding/CompiledModelTestBase.cs
Outdated
Show resolved
Hide resolved
f2cb6e5 to
a4316f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My take on adding additional handling for the following issue: #35219
Throws InvalidOperationException with proper message as in DesignStrings (CompiledModelBackingFieldNotFound and CompiledModelUnsafeAccessorNull). Plus added additional exceptions specifically for this case.