-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/9.0] Use 8.x Microsoft.Extensions.* packages #34769
Conversation
What is the reason to run benchmarks and tests with 9.0 dependencies? |
That's still the mainline scenario for EF Core 9
No, I tested it manually for net8.0 with 8.0.x dependencies. Multi-targeting all the tests is non-trivial and something that would only apply to this release. |
@AndriySvyryd, @ericstj and I were chatting - what's the servicing story here when .NET 8 ship an MSRC fix and entity framework in 9.0 needs to sim-ship that fix? |
i'm not sure what the process is for entity framework, but for the rest of the product we don't flow changes across bands. Doing so would delay builds in later versions and reset them when earlier versions rebuild. We also try to avoid these dependencies for source build, because they require explicit reference packages. Again I'm not sure if that would apply to entity framework or not. Boils down to what sort of package is entity framework. Is it part of .net versioning and servicing with .net or is it something on top? |
EF Core is shipped and serviced following the same schedule as .NET, but it's not part of source build, SDK or VS |
Closing as the servicing cost would be prohibitive. |
Description
For 9 EF still targets net8.0 to help with adoption for users staying on the LTS SDK, but we depend on 9.0.x versions of
Microsoft.Extensions.*
packages.Customer impact
When deploying an app targeting net8.0, the
Microsoft.Extensions.*
packages will be deployed too instead of using the shared framework.How found
Reported on 9 RC1 by partner team (Aspire - dotnet/aspire#5932 (review)).
Regression
No
Testing
Tested manually
Risk
Low.