[release/9.0] Don't remove non-existent foreign keys. #34614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great to see a new test added to catch this. |
SamMonoRT
approved these changes
Sep 5, 2024
artl93
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34329
Description
When a navigation to an owned entity type is ignored the entity type is removed and this cascades through the referencing owned entity types. And if one of them had a back navigation to the top owned entity type then we'll try to remove it again causing an exception.
Customer impact
An exception is thrown when ignoring a navigation to an owned entity type for the affected models. There's a workaround, but this issue is hard to diagnose for the users.
How found
Reported by a user on 8.0.7
Regression
No
Testing
Tests added.
Risk
Low.