Skip to content

Run tests on .NET 8 #31086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Run tests on .NET 8 #31086

wants to merge 2 commits into from

Conversation

bricelam
Copy link
Contributor

@roji I expect we'll need to react to the benchmark changes somewhere...

@bricelam bricelam requested a review from a team June 15, 2023 16:03
@bricelam bricelam requested review from wtgodbe and a team as code owners June 15, 2023 16:03
@bricelam

This comment was marked as resolved.

@ghost
Copy link

ghost commented Jun 15, 2023

Hello @bricelam!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Jun 15, 2023

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

@bricelam
Copy link
Contributor Author

bricelam commented Jun 15, 2023

dyld : error : Symbol not found: __ZTTNSt3__114basic_ifstreamIcNS_11char_traitsIcEEEE
  Referenced from : error : /Users/runner/work/1/s/.packages/grpc.tools/2.53.0/tools/macosx_x64/protoc (which was built for Mac OS X 12.5)
  Expected in : error : /usr/lib/libc++.1.dylib
   in /Users/runner/work/1/s/.packages/grpc.tools/2.53.0/tools/macosx_x64/protoc

/cc @JamesNK

Revert Grpc bump
@bricelam
Copy link
Contributor Author

CI version of macOS: 11
.NET 8 min required version: 10.15

@bricelam
Copy link
Contributor Author

Failed with lots of new trimming warnings /cc @roji @ajcvickers

@JamesNK
Copy link
Member

JamesNK commented Jun 15, 2023

It's a known issue in Grpc.Tools that it doesn't work in macOS 11: dotnet/aspnetcore#47336

@bricelam
Copy link
Contributor Author

Superseded by PR #31270

@bricelam bricelam closed this Jul 14, 2023
@bricelam bricelam deleted the test8 branch July 14, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants